[FSSDK-12107] refactor build system #1130
Merged
+1,625
−723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raju-opti
force-pushed
the
raju/build_refacator
branch
from
33c8155 to
775a6c5
Compare
There was a problem hiding this comment.
Pull request overview
This pull request refactors the build system by replacing the Rollup TypeScript plugin with direct TypeScript compilation followed by bundling. It also adds a TypeScript example project to verify TypeScript support and integrates a CI check for it.
Changes:
- Replaced
rollup-plugin-typescript2with directtsccompilation to.build/directory, then bundling from there - Updated Rollup plugins to newer versions and migrated from deprecated plugins to
@rollup/plugin-terser - Added
ts-example/directory with comprehensive TypeScript usage examples and test infrastructure
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Added importHelpers: true and split output between .build and dist directories |
| rollup.config.mjs | Refactored to use ES modules, updated plugins, changed input paths to .build/ |
| package.json | Updated build scripts, added tslib, updated plugin dependencies, added ts-example script |
| package-lock.json | Updated all rollup plugins and rollup itself to latest versions |
| ts-example/* | New TypeScript example project demonstrating SDK usage patterns |
| scripts/run-ts-example.js | New script to build SDK and run TypeScript example with datafile server |
| .github/workflows/javascript.yml | Added ts-check job to CI pipeline |
| .gitignore | Added .build/ directory to ignore list |
| lib/index.browser.ts | Removed extraneous blank line |
Files not reviewed (1)
- ts-example/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junaed-optimizely
approved these changes
Jan 14, 2026
Contributor
junaed-optimizely
left a comment
junaed-optimizely
left a comment
There was a problem hiding this comment.
Great work on the type test addition. Looks solid!
raju-opti
force-pushed
the
raju/build_refacator
branch
from
77247f1 to
749e806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
examples/typescriptdirectory with an example typescript project, which is used to check that typescript support is working properly.typescript_testjob to GitHub Actions workflow.Test plan
Issues